Fix a false positive for Style/ColonMethodCall
#5602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary AFAIK, It is customary to continue with `::` after `Java` used in Java package namespace in JRuby. e.g. `Java::com` (https://github.com/jruby/jruby/wiki/JDBC) If it use a class method, I think `.` is good after `Java`, but it is maybe a rare case. In this PR, it prioritize that false positives don't occur in customary usage. ## Other Information I have learned about this false positive by the following address. rsim/oracle-enhanced#1658.
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Apr 14, 2018
rubocop/rubocop#5602 addressed `Style/ColonMethodCall` false positive
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Apr 14, 2018
rubocop/rubocop#5602 addressed it and rubocop-0-54 has been enabled it codeclimate/codeclimate-rubocop#119 (comment)
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Apr 15, 2018
rubocop/rubocop#5602 addressed it and rubocop-0-54 has been enabled it codeclimate/codeclimate-rubocop#119 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AFAIK, It is customary to continue with
::afterJavaused in Java package namespace in JRuby.e.g.
Java::com(https://github.com/jruby/jruby/wiki/JDBC)If it use a class method, I think
.is good afterJava, but it is maybe a rare case. In this PR, it prioritize that false positives don't occur in customary usage.Other Information
I have learned about this false positive by the following address.
rsim/oracle-enhanced#1658.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake defaultorrake parallel. It executes all tests and RuboCop for itself, and generates the documentation.