Fix issues related to passing arguments to funcall and predicates #5539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edouard-chin
force-pushed
the
predicate-funcall-args
branch
3 times, most recently
from
7521f07 to
54bbe80
Compare
|
The changes look good to me. Just two small notes:
|
Edouard-chin
force-pushed
the
predicate-funcall-args
branch
2 times, most recently
from
665f326 to
03e37bd
Compare
Edouard-chin
changed the title
- Any predicate method call was able to receive only a single argument, otherwise an error was thrown during compilation - The reason is because the `compile_arg` method was stumbling into the `,` token (used to split earch args)
Edouard-chin
force-pushed
the
predicate-funcall-args
branch
from
03e37bd to
1fa99eb
Compare
- Passing argument to funcall (any numbers) wasn't working, the ruby code generate from the compiler wasn't valid, a closing parenthesis was misplaced. The code was looking something like ``` # Before (my_method(node0), arg1, arg2) # After (my_method(node0, arg1, arg2)) ```
Edouard-chin
force-pushed
the
predicate-funcall-args
branch
from
1fa99eb to
8c56b94
Compare
|
Thanks for the quick feedback. I have made the requested changes |
|
Thanks for working on this! I really appreciate it! 🙇 |
Drenmi
reviewed
Feb 6, 2018
| args | ||
| index = tokens.find_index { |token| token == ')' } | ||
|
|
||
| tokens.slice!(0..index).each_with_object([]) do |token, args| |
There was a problem hiding this comment.
Is it safe to mutate the passed in array here?
There was a problem hiding this comment.
👋 , if you are talking about the tokens array then I believe it should be safe to mutate it, well at least the previous implementation was already mutating it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, thanks for creating and maintaining this gem 😸
This PR fixes 2 issues I found with the compiler:
Fixed an issue with multiple args on predicates:
compile_argmethod was stumbling into the,token (used to split earch args)Fixed an issue when funcall were passed argument: