[Fix #5188] Add --no-auto-gen-timestamp option #5358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominicsayers
force-pushed
the
no-autogen-timestamp
branch
from
e500190 to
4fe365d
Compare
dominicsayers
changed the title
bbatsov
reviewed
Dec 30, 2017
| @@ -8,7 +8,7 @@ class DisabledConfigFormatter < BaseFormatter | |||
| HEADING = | |||
| ['# This configuration was generated by', | |||
| '# `%s`', | |||
| "# on #{Time.now} using RuboCop version #{Version.version}.", | |||
| "# %susing RuboCop version #{Version.version}.", | |||
There was a problem hiding this comment.
New cop idea - string array followed by .join("\n") should be replaced with a heredoc. 😄
There was a problem hiding this comment.
Fixed in most recent push
|
Apart from the failed build, the changes look good to me. |
dominicsayers
force-pushed
the
no-autogen-timestamp
branch
2 times, most recently
from
9b78c4f to
cca2f9c
Compare
An option to generate a `.rubocop_todo.yml` file that does not change unless there are substantive changes to its content. With this option and `--no-offence-counts` combined the `.rubocop_todo.yml` config should not change from run to run unless there are differences in the offences detected. This will allow developers to use automated `git diff` tests to check that the `.rubocop_todo.yml` is up-to-date. In `options.rb` the verification of the presence of `--auto-gen-config` when any of the three associated options is supplied has been consolidated. This ensures that handling of these parameters is consistent, and as a nice side-effect it allows us to remove the `args` parameter from a chain of methods right up to `define_options`.
dominicsayers
force-pushed
the
no-autogen-timestamp
branch
from
cca2f9c to
0a1aa82
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An option to generate a
.rubocop_todo.ymlfile that does not change unless there are substantive changes to its content.With this option and
--no-offence-countscombined the.rubocop_todo.ymlconfig should not change from run to run unless there are differences in the offences detected. This will allow developers to use automatedgit difftests to check that the.rubocop_todo.ymlis up-to-date.In
options.rbthe verification of the presence of--auto-gen-configwhen any of the three associated options is supplied has been consolidated. This ensures that handling of these parameters is consistent, and as a nice side-effect it allows us to remove theargsparameter from a chain of methods right up todefine_options.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake defaultorrake parallel. It executes all tests and RuboCop for itself, and generates the documentation.