Rename LiteralInCondition and RegexpInCondition to LiteralAsCondition and RegexpAsCondition #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and RegexpAsCondition - Lint/LiteralInCondition => Lint/LiteralAsCondition - Lint/RegexpInCondition => Lint/RegexpAsCondition - Improve the offense message - Improve the cop description
pocke
force-pushed
the
rename-literal-in-condition
branch
from
60a3b53 to
6752d3a
Compare
bbatsov
reviewed
Oct 15, 2017
CHANGELOG.md
Outdated
| @@ -10,7 +10,7 @@ | |||
| * [#4796](https://github.com/bbatsov/rubocop/pull/4796): Add new `Lint/RedundantWithObject` cop. ([@koic][]) | |||
| * [#4663](https://github.com/bbatsov/rubocop/issues/4663): Add new `Style/CommentedKeyword` cop. ([@donjar][]) | |||
| * Add `IndentationWidth` configuration for `Layout/Tab` cop. ([@rrosenblum][]) | |||
| * [#4854](https://github.com/bbatsov/rubocop/pull/4854): Add new `Lint/RegexpInCondition` cop. ([@pocke][]) | |||
| * [#4854](https://github.com/bbatsov/rubocop/pull/4854): Add new `Lint/RegexpInCondition` cop(Note: This cop was renamed to `Lint/RegexpAsCondition`). ([@pocke][]) | |||
There was a problem hiding this comment.
As this is unreleased I guess you can just update the name in place.
bbatsov
reviewed
Oct 15, 2017
| class RegexpInCondition < Cop | ||
| MSG = 'Do not use regexp literal in condition.' \ | ||
| class RegexpAsCondition < Cop | ||
| MSG = 'Do not use regexp literal as condition.' \ |
bbatsov
reviewed
Oct 15, 2017
config/enabled.yml
Outdated
| Description: >- | ||
| Do not use regexp literal in condition. | ||
| Do not use regexp literal as condition. |
|
Btw, on an unrelated note - probably the messages should also feature the literal in question, so they are more useful to end users. |
5 tasks
floehopper
added a commit
to alphagov/govuk-lint
that referenced
this pull request
Dec 7, 2017
By renaming the config key LiteralInCondition -> LiteralAsCondition.
The former cop was renamed in Rubocop v0.50.0 [1] and was causing the
following deprecation warning to be displayed:
Warning: unrecognized cop LiteralInCondition found in ...
[1]:
https://github.com/bbatsov/rubocop/blob/v0.51.0/CHANGELOG.md#changes
[2]: rubocop/rubocop#4864
nickcharlton
added a commit
to thoughtbot/guides
that referenced
this pull request
Dec 15, 2017
This changed with rubocop/rubocop#4864. Closes #505.
tas50
added a commit
to tas50/cookstyle
that referenced
this pull request
Dec 1, 2024
Renamed in rubocop/rubocop#4864 Signed-off-by: Tim Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #4854 (comment)
This change renames cops, and improves the message and description.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).rake spec) are passing.rake internal_investigation.and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).