Make Lint/LiteralInCondition cop aware of ! and not
#4853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
force-pushed
the
Lint/LiteralInCondition-not
branch
from
540c00a to
bbf5b52
Compare
Drenmi
reviewed
Oct 11, 2017
| @@ -65,17 +65,25 @@ def on_case(case_node) | |||
| end | |||
| end | |||
|
|
|||
| def on_send(node) | |||
| case node.method_name | |||
There was a problem hiding this comment.
I think guard clauses are commonly used for this.
Perhaps SendNode should have a predicate #negation_method?. That would allow a guard clause:
return unless node.negation_method?By this change, `Lint/LiteralInCondition` cop will register an offence for the following code. ```ruby !'foo' not 'foo' ```
pocke
force-pushed
the
Lint/LiteralInCondition-not
branch
from
bbf5b52 to
98547fa
Compare
|
👍 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By this change,
Lint/LiteralInConditioncop will register an offence for the following code.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).rake spec) are passing.rake internal_investigation.and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).