Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Style/Dir cop #4552

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Add new Style/Dir cop #4552

merged 1 commit into from
Jun 26, 2017

Conversation

Drenmi
Copy link
Collaborator

@Drenmi Drenmi commented Jun 25, 2017

This cop checks for places where the #__dir__ method can replace more complex constructs to retrieve a canonicalized absolute path to the current file.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests(rake spec) are passing.
  • The new code doesn't generate RuboCop offenses that are checked by rake internal_investigation.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

This cop checks for places where the `#__dir__` method can replace more
complex constructs to retrieve a canonicalized absolute path to the
current file.
@bbatsov bbatsov merged commit 494bef2 into rubocop:master Jun 26, 2017
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 26, 2017

Great addition! 👍 I was thinking of creating such a cop since the first days of RuboCop. 🤣

@Drenmi Drenmi deleted the feature/dir-cop branch June 30, 2017 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants