Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Lint/DuplicateMethods aware of attr_* methods #4543

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

pocke
Copy link
Collaborator

@pocke pocke commented Jun 23, 2017

Lint/DuplicateMethods cop does not offenses to the following code.

class User
  attr_reader :name

  # This definition is unnecessary, but RuboCop does not detect it.
  def name
    @name
  end
end

This change fixes the problem.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests(rake spec) are passing.
  • The new code doesn't generate RuboCop offenses that are checked by rake internal_investigation.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

`Lint/DuplicateMethods` cop does not offenses to the following code.

```ruby
class User
  attr_reader :name

  # This definition is unnecessary, but RuboCop does not detect it.
  def name
    @name
  end
end
```

This change fixes the problem.
@bbatsov bbatsov merged commit 959fc1f into rubocop:master Jun 23, 2017
@pocke pocke deleted the dup-method-attr branch June 23, 2017 06:31
@olivierlacan
Copy link

This cop causes false positives on reader method overrides that don't simply return the associated instance variable.

@SwagDevOps
Copy link

Nope, even method does not simply return, it is a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants