Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Lint/DuplicateMethods aware of alias and alias_method #4492

Merged
merged 1 commit into from
Jun 10, 2017

Conversation

pocke
Copy link
Collaborator

@pocke pocke commented Jun 10, 2017

Currently Lint/DuplicateMethods cop does not aware of alias.

For example:

class A
  def foo
  end
  def bar
  end

  # foo is redefined, but the cop does not detect it.
  alias foo bar
end

This change fixes the problem.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@pocke pocke force-pushed the alias-duplicated-method branch from 5ec6a25 to eea0592 Compare June 10, 2017 06:03
Currently `Lint/DuplicateMethods` cop does not aware of `alias`.

For example:

```ruby
class A
  def foo
  end
  def bar
  end

  # foo is redefined, but the cop does not detect it.
  alias foo bar
end
```

This change fixes the problem.
@pocke pocke force-pushed the alias-duplicated-method branch from eea0592 to cccdfa3 Compare June 10, 2017 06:30
@Drenmi
Copy link
Collaborator

Drenmi commented Jun 10, 2017

Good catch! 🙂

@bbatsov bbatsov merged commit 61aa350 into rubocop:master Jun 10, 2017
@pocke pocke deleted the alias-duplicated-method branch June 11, 2017 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants