Enable Style/Encoding by default #4445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cop was made a disabled by default cop back when Ruby 1.9 was still supported and there was no `never` enforced style. This is not the case any more, so we can start making sure that projects do not include unnecessary encoding magic comments by default.
|
👍 |
|
Thanks! :) |
bquorning
reviewed
Jul 21, 2017
| @@ -6,6 +6,10 @@ | |||
|
|
|||
| * [#4443](https://github.com/bbatsov/rubocop/pull/4443): Prevent `Style/YodaCondition` from breaking `not LITERAL`. ([@pocke][]) | |||
|
|
|||
| ### Changes | |||
|
|
|||
| * [#4444](https://github.com/bbatsov/rubocop/pull/4444): Make `Style/Encoding` cop enabled by default. ([@deivid-rodriguez][]) | |||
bquorning
added a commit
to bquorning/rubocop
that referenced
this pull request
Jul 22, 2017
11 tasks
bbatsov
pushed a commit
that referenced
this pull request
Jul 23, 2017
5 tasks
tonyta
added a commit
to tonyta/fix-db-schema-conflicts
that referenced
this pull request
Oct 25, 2017
As of RuboCop v0.50.0, the Style/Encoding cop is now enabled by default and configured to remove the encoding magic-comment. This deviates from the expected behavior in specs and changes the behavior of this gem. Disabling this cop will ensure that fix_db_schema_conflicts will output consistently regardless of RuboCop version. Change in RuboCop: rubocop/rubocop#4445
284km
added a commit
to 284km/guard-rubocop
that referenced
this pull request
Oct 30, 2017
As of RuboCop v0.50.0, the Style/Encoding cop is now enabled by default and configured to remove the encoding magic-comment. Details here: rubocop/rubocop#4445
rkledesma
added a commit
to rentpath/style-guides
that referenced
this pull request
Feb 21, 2018
Style/Encoding is enabled by default now, and the presence of this setting is throwing errors blocking rubocop execution with newer versions of rubocop see: rubocop/rubocop#4445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cop was made a disabled by default cop back when Ruby 1.9 was still
supported and there was no
neverenforced style. This is not the caseany more, so we can start making sure that projects do not include
unnecessary encoding magic comments by default.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).