Require a space before first argument of a method call #4265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🐬 |
|
^ LGTM |
Drenmi
reviewed
Apr 12, 2017
CHANGELOG.md
Outdated
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| ## master (unreleased) | |||
|
|
|||
| ### New features | |||
There was a problem hiding this comment.
There's a section called Changes where we normally put changes to existing cops, although this might even qualify as a bug fix. 🙂
|
Great first contribution! ❤️ |
bbatsov
reviewed
Apr 12, 2017
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### Bug fixes | |||
|
|
|||
| * [#4265](https://github.com/bbatsov/rubocop/pull/4265): Require a space before first argument of a method call in `Style/SpaceBeforeFirstArg` cop. ([@cjlarose][]) | |||
There was a problem hiding this comment.
You have to add yourself to the bottom of the changelog.
There was a problem hiding this comment.
Sorry about that! Updated the CHANGELOG with a link to myself.
Ruby permits a method name to be followed immediately by a string literal, with no space between them. This change updates the SpaceBeforeFirstArg cop to register a violation for source code that does this.
cjlarose
force-pushed
the
require-space-between-method-name-and-argument
branch
from
90b62af to
b2d627e
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ruby parser appears to be completely fine with something like
The cop
Style/SpaceBeforeFirstArgclaims to check that "exactly one space is used between a method name and the first argument for method calls without parentheses", but does not account for source code that has zero spaces between the method name and the first argument.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).