Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark foo[:bar] as not complex in Style/TernaryParentheses cop #4012

Merged

Conversation

onk
Copy link
Contributor

@onk onk commented Feb 3, 2017

Square brackets behavior is now same as Style/RedundantParentheses.

# EnforcedStyle: require_parentheses_when_complex
#
# # bad
# foo = (bar[:baz]) ? a : b
#
# # good
# foo = bar[:baz] ? a : b

It seems better to extract non_complex_type? to mixin and
Style/RedundantParentheses and Style/TernaryParentheses
use it even if incompatibility comes.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

Square brackets behavior is now same as Style/RedundantParentheses.

```
# EnforcedStyle: require_parentheses_when_complex
#
# # bad
# foo = (bar[:baz]) ? a : b
#
# # good
# foo = bar[:baz] ? a : b
```

It seems better to extract `non_complex_type?` to mixin and
`Style/RedundantParentheses` and `Style/TernaryParentheses`
use it even if incompatibility comes.
@onk onk force-pushed the feature/ternary_parentheses_with_square_brackets branch from edd0c52 to 086e21b Compare February 3, 2017 11:00
@bbatsov
Copy link
Collaborator

bbatsov commented Feb 4, 2017

It seems better to extract non_complex_type? to mixin and
Style/RedundantParentheses and Style/TernaryParentheses
use it even if incompatibility comes.

Yeah, guess this would be best.

@bbatsov bbatsov merged commit d5aa4db into rubocop:master Feb 4, 2017
@onk onk deleted the feature/ternary_parentheses_with_square_brackets branch February 5, 2017 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants