Add new Lint/SafeNavigationChain cop
#3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safe navigation operator returns nil if the receiver is nil. So if you chain an ordinary method call after safe navigation operator, it raises NoMethodError. We should use safe navigation operator after safe navigation operator. This cop checks the problem. For example ```ruby x = nil x&.foo.bar # => NoMethodError: undefined method `bar' for nil:NilClass x&.foo&.bar # => nil ```
pocke
force-pushed
the
cop-for-safe-navigation-chain
branch
from
eac22bc to
c9a3d08
Compare
|
Another great contribution! Thanks! 👍 ❤️ 🚀 |
Drenmi
reviewed
Dec 20, 2016
|
|
||
| def autocorrect(node) | ||
| dot = node.loc.dot | ||
| return unless node.loc.dot |
There was a problem hiding this comment.
It's a bit late now, but I guess we could have used the local variable dot here. 😀
There was a problem hiding this comment.
I'll fix this myself. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safe navigation operator returns nil if the receiver is nil.
So if you chain an ordinary method call after safe navigation operator, it raises NoMethodError.
We should use safe navigation operator after safe navigation operator.
This cop checks the problem.
For example
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).