[Fix #1971] Add space style for SpaceInsideStringInterpolation
#2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotrevor
force-pushed
the
space_config_style_for_string_interpolation_rebase
branch
from
2966607 to
80b3e02
Compare
gotrevor
force-pushed
the
space_config_style_for_string_interpolation_rebase
branch
from
80b3e02 to
ed4beeb
Compare
gotrevor
changed the title
space option for SpaceInsideStringInterpolationspace style for SpaceInsideStringInterpolation
| # Good: | ||
| # var = "This is the #{good} example" | ||
| # @example | ||
| # Good: |
There was a problem hiding this comment.
You can convert good and bad into line comments, for consistency with the rest of our code.
|
Apart from my small remarks, the changes look good. 👍 |
bbatsov
added a commit
that referenced
this pull request
Jul 4, 2015
…interpolation_rebase [Fix #1971] Add `space` style for SpaceInsideStringInterpolation
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.