Support class method visibility modifiers in DefEndAlignment #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok, but has to be rebased. |
Make sure DefEndAlignment recognizes def lines preceded with private_class_method or public_class_method, and does not complain about misaligned end, like this: private_class_method def self.foo ... end
til
force-pushed
the
def-end-alignment-class-method-modifiers
branch
from
f006694 to
d15466a
Compare
|
OK, rebased and pushed. |
bbatsov
added a commit
that referenced
this pull request
Apr 22, 2015
…fiers Support class method visibility modifiers in DefEndAlignment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure
DefEndAlignmentrecognizes def lines preceded withprivate_class_methodorpublic_class_method, and does not complain aboutmisaligned
end, like this: