Add style cop that checks for inline comments

[salbertson]

• Create custom matcher for testing offenses

[bbatsov]

Looks good. Please, a changelog entry.

[geniou]

Usually the number of offenses, the line number, the message and the highlights are checked in the specs. I think this is here useful too. Just take a look in the newly added specs.

[bbatsov]

@salbertson Ping :-)

[salbertson]

@bbatsov, I'll make those changes soon. Thanks for checking in.

[salbertson]

@geniou, would you link to a test that checks the things you mentioned? I looked at a couple recent Cop specs and didn't find any tests for line numbers, message or highlights.

[geniou]

@salbertson good question - I think @bbatsov has to decide. General it would be good if all (new) specs test these things, but I'm not sure if its wise / possible to enforce it.

[bbatsov]

@salbertson Message checking makes sense only if the cop does dynamic message generation. Most cops should do highlights checking in the specs, but older don't as we hadn't originally devised this check.

Personally, I rarely check the line numbers of the offenses in the specs I write.

Anyways, you can have a look at the variable_name_spec.rb and the trivial_accessors_specs.rb for example code.

[salbertson]

@bbatsov Great, thanks.

[salbertson]

@bbatsov @geniou Sorry this took a while. I'd appreciate another review when you have a chance.

I added a custom matcher to make testing for offenses and highlighted easier. Hopefully the new matcher will encourage others to test for highlights along with offenses.

[salbertson]

I also added a matcher that to help test messages.

[bbatsov]

👍 The code looks good.