-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add progress bar to offense formatter #5675
Conversation
Definitely.
Yeah, it's good idea. But I think the progress-bar should be hidden if the output is not a tty. I guess we would like to use the formatter output as an input of some program sometimes. For example: |
d80a800
to
4463944
Compare
That makes a lot of sense. I made the requested change! |
4463944
to
3572707
Compare
Thanks for working on this! I really appreciate it! 🙇 |
When you run
bundle exec rubocop --format offenses
there is no output until rubocop has run completely. It is not very user friendly when run over large codebases where you might go a few minutes before rubocop shows any sign that it is indeed properly running.This PR simply adds a progress bar so the user knows rubocop is running.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).and description in grammatically correct, complete sentences.
rake default
orrake parallel
. It executes all tests and RuboCop for itself, and generates the documentation.