Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout/IndentHeredoc cop for EOS #4634

Closed
sonncui opened this issue Jul 30, 2017 · 0 comments
Closed

Layout/IndentHeredoc cop for EOS #4634

sonncui opened this issue Jul 30, 2017 · 0 comments
Assignees
@pocke
Labels
bug

Comments

@sonncui
Copy link

sonncui commented Jul 30, 2017

Expected behavior

Layout/IndentHeredoc cop should work for EOS

Actual behavior

An error occurred while Layout/IndentHeredoc cop was inspecting ...

Steps to reproduce the problem

In my file, I define a multiline string like:

content = <<-EOS

EOS

RuboCop version

Include the output of rubocop -V. Here's an example:

$ rubocop -V
0.49.1 (using Parser 2.4.0.0, running on ruby 2.2.2 x86_64-darwin15)
@pocke pocke added the bug label Jul 30, 2017
@pocke pocke self-assigned this Jul 30, 2017
pocke added a commit to pocke/rubocop that referenced this issue Jul 30, 2017
@pocke
[Fix rubocop#4634] Handle heredoc that contains empty lines only in `…
d36d6d4 
…Layout/IndentHeredoc` cop

Fix rubocop#4634

Problem
======

If a heredoc contains empty lines only, the cop raises an error.

Solution
======

The cop does not add any offences in that case.
@pocke pocke mentioned this issue Jul 30, 2017
Merged
11 tasks
bbatsov pushed a commit that referenced this issue Aug 1, 2017
@pocke @bbatsov
[Fix #4634] Handle heredoc that contains empty lines only in `Layout/…
c3a9ad5 
…IndentHeredoc` cop

Fix #4634

Problem
======

If a heredoc contains empty lines only, the cop raises an error.

Solution
======

The cop does not add any offences in that case.
@mpotter mpotter mentioned this issue Oct 21, 2017
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pocke pocke

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pocke @sonncui