.spec pattern clashes with RPM spec files

[iainbeeston]

Expected behavior

I'd expect rubocop to only parse ruby files, and ignore any files that are not ruby files.

Actual behavior

Rubocop is trying to parse ".spec" files in my project's node_modules directory, which are rpm spec files, not ruby files, and it throws an error because it cannot parse them.

Steps to reproduce the problem

I've added a sample rails app that reproduces the issue here, which has a travis build to show the issue here

To reproduce manually:

1. rails new --webpack=react foo
2. cd foo
3. Add rubocop to Gemfile
4. bundle install
5. bundle exec rake yarn:install
6. rubocop

RuboCop version

$ rubocop -V
0.49.1 (using Parser 2.4.0.0, running on ruby 2.4.1 x86_64-darwin16)

[iainbeeston]

I can see that by default rubocop loads .spec files in config/default.yml.

However, I suspect that the correct way to fix this would to be ignore node_modules/**/* by default. Especially as it's a standard directory now in rails 5.1?

[Drenmi]

RuboCop tries to make as few library specific exceptions as possible, since it is a Ruby analyzer. That said, having a node_modules in the same directory is not really library specific, and I personally (I'm not a maintainer) wouldn't be opposed to having this ignored by default. (The chance of someone having a directory, node_modules, with Ruby code is practically 0.) 🙂

Care to make a PR to have it tested? 🙂