Style/ClosingParenthesisIndentation Changes

[jfelchner]

I want to outline my goals here and try to get some discussion started.

Goal

I'd like to update the Style/ClosingParenthesisIndentation cop to be more robust and handle specific indentation scenarios. Currently the Style/ClosingParenthesisIndentation cop is pretty basic which unfortunately means that it doesn't achieve the desired result in a lot of cases.

Examples

        hello_this_is_my_variable = what.could.this_method_be_doing(
                                      i_dunno: 'but',
                                      i_like:  'it',
)

It's fairly clear from this code that the developer would want to align the parenthesis with the opening one. Because this:

        hello_this_is_my_variable = what.could.this_method_be_doing(
                                      i_dunno: 'but',
                                      i_like:  'it',
        )

looks ridiculous. However in the same codebase, there may be a case like this:

        what.could.this_method_be_doing(
          i_dunno: 'but',
          i_like:  'it',
)

where it's fairly obvious to the reader that the right paren should be aligned by the beginning of the line with the method call.

There's also an (albeit weirder) situation like this:

        what.could.this_method_be_doing(i_dunno: 'but',
                                        i_like:  'it',
)

Where the right paren should be aligned with the right paren. Even though that looks weird, it looks better than the current result of this cop, which is:

        what.could.this_method_be_doing(i_dunno: 'but',
                                        i_like:  'it',
        )

Possibilities

What I'd like to do is have a discussion about the possible changes to the Style/ClosingParenthesisIndentation which could cover these use cases.

[jfelchner]

Ping @jonas054 @Drenmi 😁

[bbatsov]

I might be missing something, but it's unclear to me whether you're reporting a bug or proposing an improvement.

[jfelchner]

@bbatsov improvement for the most part. I believe the cop only handles one simple case. I'm asking for feedback on configuration changes that would allow it to handle the cases outlined above.