-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive in Rails/FilePath cop #3947
Labels
Comments
jspanjers
added a commit
to jspanjers/rubocop
that referenced
this issue
Jan 28, 2017
10 tasks
lucascaton
changed the title
Rails/FilePath cop complains even when I have the expected code
False positive in Rails/FilePath cop
Mar 27, 2017
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this issue
Jan 14, 2018
Fixes rubocop#3947 and Fixes rubocop#3974. This PR is the takeover of rubocop#4178. It fixes a false positive for `Rails/FilePath` when using `Rails.root.join` in string interpolation of argument. In addition, the following review comments are reflected in the test cases. - rubocop#4178 (comment) - rubocop#4178 (comment)
bbatsov
pushed a commit
that referenced
this issue
Jan 14, 2018
Fixes #3947 and Fixes #3974. This PR is the takeover of #4178. It fixes a false positive for `Rails/FilePath` when using `Rails.root.join` in string interpolation of argument. In addition, the following review comments are reflected in the test cases. - #4178 (comment) - #4178 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
Rails/FilePath
cop (PR) shouldn't complain when I have the following code:Actual behavior
$ rubocop --only Rails/FilePath
RuboCop version
Thank you.
The text was updated successfully, but these errors were encountered: