[Fix #3426] Fixes Style/RedundantParentheses for indexing with literals. #3592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Oct 10, 2016
| @@ -31,6 +31,7 @@ | |||
| * [#3390](https://github.com/bbatsov/rubocop/issues/3390): Fix SaveBang cop for multiple conditional. ([@tejasbubane][]) | |||
| * [#3577](https://github.com/bbatsov/rubocop/issues/3577): Fix `Style/RaiseArgs` not allowing compact raise with splatted args. ([@savef][]) | |||
| * [#3578](https://github.com/bbatsov/rubocop/issues/3578): Fix safe navigation method call counting in `Metrics/AbcSize`. ([@savef][]) | |||
| * [#3592](https://github.com/bbatsov/rubocop/issues/3592): Fix `Style/RedundantParentheses` for indexing with literals ([@thegedge][]) | |||
There was a problem hiding this comment.
This line should have a . before your name. You should also add yourself to the end of the file.
Yeah, that's OK. |
Style/RedundantParentheses would not report an offense when parentheses surrounded an indexing operation for a literal, but would work with a regular function call.
|
👍 |
Neodelf
pushed a commit
to Neodelf/rubocop
that referenced
this pull request
Oct 15, 2016
… literals (rubocop#3592) Style/RedundantParentheses would not report an offense when parentheses surrounded an indexing operation for a literal, but would work with a regular function call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style/RedundantParentheseswould not report an offense when parentheses surrounded an indexing operation for a literal, but would work with a regular function call. This PR fixes this issue by also including strings, arrays, and hashes in the node matcher.I stuck with the
a method calloffense, but perhaps there's a better wording (even though technically it is a method call to:[])?Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.