Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow TrailingCommaInLiteral to enforce Arrays but not Hashes #3394

Closed
CyborgMaster opened this issue Aug 9, 2016 · 1 comment
Closed

Allow TrailingCommaInLiteral to enforce Arrays but not Hashes #3394

CyborgMaster opened this issue Aug 9, 2016 · 1 comment
Labels
feature request

Comments

@CyborgMaster
Copy link

I would like TrailingCommaInLiteral to be enforced for arrays, but not hashes. Could that be done with a configuration option?
@garettarrowood
Copy link
Contributor

garettarrowood commented Dec 24, 2017 •
edited
Loading

Reviewing the cop, I do not believe a new config option is the way to go. There are already no_comma, comma & consistent_comma config options. This looks like a good candidate to break into 2 Cops, TrailingCommaInArrayLiteral & TrailingCommaInHashLiteral. This will allow unique configuration for both data types.

@garettarrowood garettarrowood mentioned this issue Dec 24, 2017
Merged
8 tasks
garettarrowood added a commit to garettarrowood/rubocop that referenced this issue Dec 27, 2017
@garettarrowood
[Fix rubocop#3394] Separate Array & Hash Literal Comma configuration
7df4639
garettarrowood added a commit to garettarrowood/rubocop that referenced this issue Dec 27, 2017
@garettarrowood
[rubocop#3394] Update CHANGELOG with new TrailingComma changes
6678924
bbatsov pushed a commit that referenced this issue Dec 27, 2017
@garettarrowood @bbatsov
[Fix #3394] Separate Array & Hash Literal Comma configuration
aa575ff
bbatsov pushed a commit that referenced this issue Dec 27, 2017
@garettarrowood @bbatsov
[#3394] Update CHANGELOG with new TrailingComma changes
ea711b8
@dependencies dependencies bot mentioned this issue Mar 5, 2018
Open
skalee added a commit to skalee/guides that referenced this issue Mar 6, 2018
@skalee
Replace removed Rubocop cop
e8f7f7c 
In Rubocop 0.53, Style/TrailingCommaInLiteral has been replaced with
Style/TrailingCommaInArrayLiteral, and Style/TrailingCommaInHashLiteral.

See: rubocop/rubocop#3394.
nickcharlton pushed a commit to thoughtbot/guides that referenced this issue Mar 13, 2018
@skalee @nickcharlton
Upgrade Rubocop style guide for version 0.53 (#510)
c61c8cd 
* Replace removed Rubocop cop

In Rubocop 0.53, Style/TrailingCommaInLiteral has been replaced with
Style/TrailingCommaInArrayLiteral, and Style/TrailingCommaInHashLiteral.

See: rubocop/rubocop#3394.

* Move Rubocop cop to proper namespace

In Rubocop 0.53, Lint/ConditionPosition has been moved to Layout
namespace.

* Rename Rubocop cop

In Rubocop 0.53, Lint/UnneededDisable has been renamed to
Lint/UnneededCopDisableDirective.
@NickLaMuro NickLaMuro mentioned this issue Mar 14, 2018
Closed
@dependabot-preview dependabot-preview bot mentioned this issue Mar 19, 2018
Closed
@prollinson prollinson mentioned this issue Apr 2, 2018
Merged
hilliuse added a commit to hilliuse/simplecov-html that referenced this issue May 18, 2018
@hilliuse
TrailingCommaInLiteral was split in rubocop 0.53.0
3702772 
https://github.com/bbatsov/rubocop/blob/v0.53.0/CHANGELOG.md
rubocop/rubocop#3394
https://github.com/bbatsov/rubocop/pull/5307/files#diff-e93280b3b31a6438c533a5f3232340d8
@hilliuse hilliuse mentioned this issue May 18, 2018
Merged
nickcharlton added a commit to nickcharlton/dotfiles that referenced this issue May 20, 2018
@nickcharlton
Upgrade Rubocop style guide for version 0.53
4752525 
* Replace removed Rubocop cop

In Rubocop 0.53, Style/TrailingCommaInLiteral has been replaced with
Style/TrailingCommaInArrayLiteral, and Style/TrailingCommaInHashLiteral.

See: rubocop/rubocop#3394.

* Move Rubocop cop to proper namespace

In Rubocop 0.53, Lint/ConditionPosition has been moved to Layout
namespace.

* Rename Rubocop cop

In Rubocop 0.53, Lint/UnneededDisable has been renamed to
Lint/UnneededCopDisableDirective.

Original: thoughtbot/guides#510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CyborgMaster @Drenmi @garettarrowood