Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style/AsciiComments should pinpoint the exact character location #3230

Closed
grosser opened this issue Jun 16, 2016 · 0 comments
Closed

Style/AsciiComments should pinpoint the exact character location #3230

grosser opened this issue Jun 16, 2016 · 0 comments

Comments

@grosser
Copy link
Contributor

grosser commented Jun 16, 2016

Some unicode characters are invisible / hard to see ... so it would be great if we can get an exact location.

# foobar ∂

atm results in foo.rb:4:1 Style/AsciiComments: Use only ascii symbols in comments
but it would be much nicer if it pinpointed the exact location (or position of first violation in this line):

`foo.rb:4:8 Style/AsciiComments: Use only ascii symbols in comments`
Drenmi added a commit to Drenmi/rubocop that referenced this issue Jul 3, 2016
This change adds smarter highlighting for the `Style/AsciiComments`
cop. It will highlight the first consecutive range of non-ascii
characters in the comments, rather than the whole expression.
@bbatsov bbatsov closed this as completed in 1eed46d Jul 4, 2016
Neodelf pushed a commit to Neodelf/rubocop that referenced this issue Oct 15, 2016
…op (rubocop#3279)

This change adds smarter highlighting for the `Style/AsciiComments`
cop. It will highlight the first consecutive range of non-ascii
characters in the comments, rather than the whole expression.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant