Lint/UselessAccessModifier thinks a private attr_writer is useless

[maxjacobson]

Consider this code:

class DogWalker
  attr_reader :dogs

  def initialize(*dogs)
    @dogs = dogs
  end

  def add_dog(dog)
    self.dogs = dogs + [dog]
  end

  private

  attr_writer :dogs
end

walker = DogWalker.new("milo", "lola")
walker.add_dog("Bean") # (uses the private attr_writer)
walker.dogs = [1, 2, 3] # (tries to use the attr_writer but fails because it's private)

The attr_writer :dogs there is private, but this generates a Lint/UselessAccessModifier offense even though sometimes it is useful to define a private setter (not sure how useful this particular example is 😄)

[maxjacobson]

This is on the latest master (0195325) -- I'm trying it out on some of our code to see what's new 😄

[alexdowad]

Good point. Just fixing this.

[alexdowad]

I had attr, attr_reader, and attr_accessor covered, but not attr_writer.

[alexdowad]

OK, just pushed a fix here.