Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing syntax warnings. #233

Closed
wants to merge 1 commit into from
Closed

Fix missing syntax warnings. #233

wants to merge 1 commit into from

Conversation

mestachs
Copy link

@mestachs mestachs commented Jun 5, 2013

Syntax ruby -wc warnings were no more considered as offences.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling fdeedc9 on mestachs:bugfix/missing-syntax-warnings into 8300d50 on bbatsov:master.

@bbatsov bbatsov closed this in ed4ede4 Jun 5, 2013
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 5, 2013

Yep, this is a bug. However, the solutions should be a bit different. I've pushed a fix. Thanks reporting the problem and the suggested solution!

@mestachs
Copy link
Author

mestachs commented Jun 5, 2013

thanks

@mestachs mestachs deleted the bugfix/missing-syntax-warnings branch June 5, 2013 11:05
bbatsov pushed a commit that referenced this pull request Jun 5, 2013
Fix #233 - report syntax cop offences
53b3406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mestachs @coveralls @bbatsov