Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint/UnneededDisable cop can't be disabled inline #1959

Closed
jfelchner opened this issue Jun 9, 2015 · 2 comments · Fixed by #1967
Closed

Lint/UnneededDisable cop can't be disabled inline #1959

jfelchner opened this issue Jun 9, 2015 · 2 comments · Fixed by #1967

Comments

@jfelchner
Copy link
Contributor

I tried to disable the Lint/UnneededDisable on a line that has some standard disablings that I wrap all my validations in and it threw an error that Lint/UnneededDisable didn't need to be disabled 😀
@rrosenblum
Copy link
Contributor

Should this cop be allowed to be disabled?

@jfelchner
Copy link
Contributor Author

Of course. Why wouldn't it be able to be?

@rrosenblum rrosenblum mentioned this issue Jun 11, 2015
Merged
rrosenblum added a commit to rrosenblum/rubocop that referenced this issue Jun 22, 2015
@rrosenblum
[Fix rubocop#1959] Allow Lint/UnneededDisable to be inline disabled
fcf17a1
bbatsov added a commit that referenced this issue Jun 22, 2015
@bbatsov
Merge pull request #1967 from rrosenblum/inline_disable_unneeded_disable
b7216c4 
[Fix #1959] Allow Lint/UnneededDisable to be inline disabled
@rrosenblum rrosenblum mentioned this issue Oct 25, 2017
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #1959] Allow Lint/UnneededDisable to be inline disabled rrosenblum/rubocop
2 participants
@jfelchner @rrosenblum