Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser incompatibility #1806

Closed
jonas054 opened this issue Apr 18, 2015 · 3 comments
Closed

Parser incompatibility #1806

jonas054 opened this issue Apr 18, 2015 · 3 comments
Assignees

Comments

@jonas054
Copy link
Collaborator

Version 2.2.0.4 introduced [some changes](https://github.com/whitequark/parse r/compare/v2.2.0.3...v2.2.0.4), one of which came from this commit. It made a change in how comments are associated to code that affected the Style/Documentation cop. This is why the build of RuboCop is currently failing.

The affected code in documentation.rb is a workaround for a problem, I think, and the recent change in Parser is a correction. I'm unsure if the change follows the Semantic Versioning rules, but it makes no difference for us, given the way we specify the dependency:

s.add_runtime_dependency('parser', '>= 2.2.0.1', '< 3.0')

We should just update Style/Documentation and change the dependency to

s.add_runtime_dependency('parser', '>= 2.2.0.4', '< 3.0')
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 18, 2015

What about whitequark/parser#190?

@bbatsov
Copy link
Collaborator

bbatsov commented Apr 18, 2015

Or maybe I didn't read the other issue carefully enough. :-)

@jonas054
Copy link
Collaborator Author

Yeah, I think this one's in our own hands. I'll push a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants