Not finish to search files when there is a directory named ","

[naoty]

I'm using 0.28.0 and ruby 2.1.5. When there is a directory named ,, rubocop command will not finish. I exclude , directory like below to fix this. The , character in the pattern to search files should be escaped.

AllCops:
  Exclude:
    - ",/**/*"

[bquorning]

I cannot reproduce this error:

Code/rubocop-test » tree -a
.
├── ,
│   └── foo.rb
├── .rubocop.yml
└── foo.rb

1 directory, 3 files

Code/rubocop-test » cat .rubocop.yml
AllCops:
  Exclude:
    - ",/**/*"

Code/rubocop-test » rubocop --version
0.28.0

Code/rubocop-test » rubocop
Inspecting 1 file
.

1 file inspected, no offenses detected

[naoty]

Sorry for my poor description. I can reproduce this problem.

% tree .
.
├── ,
│   └── foo.rb
└── foo.rb
% rubocop
(not finished)

[bquorning]

Ah, I see. The problem is in TargetFinder#find_files, where the “wanted toplevel dirs” (which includes ,) are joined together into a Dir.glob pattern. And the dirs are joined by commas…

I’ll try to come up with a solution.