Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AvoidFor cop misses many violations #159

Closed
jonas054 opened this issue May 11, 2013 · 0 comments
Closed

AvoidFor cop misses many violations #159

jonas054 opened this issue May 11, 2013 · 0 comments

Comments

@jonas054
Copy link
Collaborator

For example in:

def func
  for i in (0..2)
    puts i
  end
end

no offences are detected.

I'm working on a solution.
jonas054 added a commit to jonas054/rubocop that referenced this issue May 11, 2013
@jonas054
Fix for rubocop#159. Correct a bug in Cop#keywords.
1ddf438 
In the old code we get stuck pushing and popping keywords when 'def'
is the last keyword in the list. Reworked the algorithm a bit.
@jonas054 jonas054 mentioned this issue May 11, 2013
Merged
@bbatsov bbatsov closed this as completed May 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbatsov @jonas054