-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--display-cop-names from .rubocop.yml? #1324
Comments
We have a similar problem. We use rubocop with jish/pre-commit for Git commit hooks and want commits to be prevented only when issues with severity of In any case, it would be nice to be able to specify per-project defaults in |
Not sure about this. I don't want to introduce more complexity to the config, but I recognize the usefulness of being able to pass some command line params by default. Guess we can have an option like @jonas054 @yujinakayama What do you think about this? |
I think aside from passing default command line options, it would still make sense to be able to configure display-cop-names and fail-level in rubocop.yml. It would be a great way to say "in our team, everything below an error is not critical" and have a central location to store this information. Of course, the command line options would need to override that. |
@jonas054 @yujinakayama @bbatsov any updates on this? I'd love to see something like this in rubocop.yml:
Thanks for your hard work! |
I think @padde was right in opening an issue with jish/pre-commit. Commands take arguments. Tools that call external commands should be able to send arguments. Should RuboCop implement default arguments though configuration anyway? Only if many people need it and can't solve their problems any other way. Because it would add complexity, and I'm not sure it's necessary. |
@jonas054 thanks for your feedback. Working myself on a PR for jish/pre-commit now ;-) |
I'd suggest we postpone this for now. I don't want to do changes to the configuration logic until @yujinakayama is ready with its redesign. |
+1 |
Just throwing in my $0.02 that it would be great to be able to configure CLI options from |
Likewise, this would be really handy. |
👍 This would be incredibly useful. We have a lot of student developers who may or may not remember to set all the correct flags when they run rubocop locally, so being able to configure them from |
I think that what stops me or anyone from getting started on an implementation is the fact that there are today 20 command line options. Some of them make sense as configuration options, some don't. Some are easy to implement as configuration options, some are hard. My suggestion is that we handle only the option originally requested in this issue; |
Fair enough. On Sunday, January 4, 2015, Jonas Arvidsson [email protected]
Best Regards, |
@mnquintana Yes, please create it. |
I'm not fond of meta-issues that stay open forever. Let's wrap this first. On Sunday, January 4, 2015, Jonas Arvidsson [email protected]
Best Regards, |
@bbatsov Fair enough. What about a label / milestone? (Just something to keep track of each individual issue as they crop up.) |
Having a custom label for this type of issues sounds fine. |
[Fix #1324] Add AllCops/DisplayCopNames config option
I'd love to be able to use: AllCops/DisplayCopNames and AllCops/DisplayStyleGuide would be hugely useful for our team - particularly with houndci integration |
Can I specify to always use the flag
--display-cop-names
from my .rubocop.yml?The text was updated successfully, but these errors were encountered: