Enable Style/Encoding for Ruby >= 2.0

[yous]

Though I mainly develop and use RuboCop on Ruby 2.1, I want to force to use # encoding: utf-8 comment on every file for Ruby 1.9 compatibility. But now RuboCop doesn't do anything with Ruby 2.0.

Style/Encoding cop has SupportedStyles as always and when_needed so I thought cop registers an offense for every Ruby version when I set always to EnforcedStyle, for Ruby < 2.0 when I set when_needed to EnforcedStyle. But it doesn't mean it, it was about content of file.

Is there any idea to enable Encoding cop for every Ruby version, like adding a style to SupportedStyles?

[bbatsov]

I agree the current behaviour is less than ideal.

Is there any idea to enable Encoding cop for every Ruby version, like adding a style to SupportedStyles?

Perhaps. Alternative we can just remove the Ruby 2.0 check and make the cop disabled by default, which sounds like a better idea to me.

@yujinakayama @jonas054 Thoughts?

[jonas054]

I would suggest adding a new configuration parameter:

Style/Encoding:
  # If false, checks are only made when running under Ruby 1.9.
  ForAllRubyVersions: false

Disabling the cop doesn't really solve this issue, and adding a SupportedStyle gets complicated as ruby version and file contents can vary independently and we need to support combinations.

[bbatsov]

Unless a project supports 1.9, running the cop makes zero sense. If a project supports 1.9 than the existing configs - when_needed and always are quite sufficient. Seems to me we'll be complicating this more than it's needed with an extra config option.

[yujinakayama]

Alternative we can just remove the Ruby 2.0 check and make the cop disabled by default, which sounds like a better idea to me.

I agree.

I've also been thinking the current Encoding cop behavior is odd. If a team declared that encoding comments are always required in a project, it should be always checked regardless of each local runtime environment since it's a project-specific thing (like RuboCop project itself).

Also, we've forgotten to add encoding comments several times carelessly, but it's something we want to automate with RuboCop.

• 63b17a5
• 5632891
• 6a1df12

By the way, though I have no strong opinion on whether it should be enabled by default or not, the maintenance support for Ruby 1.9.3 will end on Feb 23, 2015.

• https://www.ruby-lang.org/en/news/2014/01/10/ruby-1-9-3-will-end-on-2015/

[jonas054]

@bbatsov When you said "remove the Ruby 2.0 check", I read it as "remove the check when running Ruby 2.0". So forget what I said. I agree with what you actually said.