Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing yamler to syck #1227

Closed
mmb opened this issue Jul 25, 2014 · 1 comment
Closed

Changing yamler to syck #1227

mmb opened this issue Jul 25, 2014 · 1 comment
Assignees

Comments

@mmb
Copy link

mmb commented Jul 25, 2014

Updating to the latest rubocop in my rails app broke delayed_job by switching the YAML::ENGINE.yamler to syck.

Granted I'm using an older 1.9.3 version of ruby but could the empty yaml problem be handled in a way other than globally setting the yamler to the old broken one? It seems like this might cause some unexpected issues.

@jonas054
Copy link
Collaborator

Yes, that's probably a good idea. I didn't consider other applications using RuboCop as a library when I implemented the fix for the empty YAML file problem. I'll try to sort it out.

@jonas054 jonas054 self-assigned this Jul 25, 2014
bbatsov added a commit that referenced this issue Aug 2, 2014
[Fix #1227] Don't permanently change yamler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants