If checkstyle file is named checkstyle.xml we fail

[fzakaria]

I noticed this bug at

rules_jvm/java/private/checkstyle.bzl

Line 22 in 50fec79

"$OLDPWD/{lib} -o checkstyle.xml -f xml -c {config} {srcs}".format(

If the input file is also called checkstyle.xml this fails as it fails to write to the file it is reading from.

Additionally:
I've noticed that Bazel doesn't emit the junit.xml file created to STDOUT when errors are present.
Developers have complained having to cat the XML file individually locally.

I'm considering adding an echo to the test if there is a failure wdyt?

CC @vinnybod