Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add Landmark attention #109

Closed
NanoCode012 opened this issue May 30, 2023 · 1 comment · Fixed by #169
Closed

[Feature] Add Landmark attention #109

NanoCode012 opened this issue May 30, 2023 · 1 comment · Fixed by #169
Labels
enhancement New feature or request

Comments

@NanoCode012
Copy link
Collaborator

Per request from Discord to add this feature.

They seem to monkeypatch LlamaModel and add special mem token.

Ref: https://github.com/epfml/landmark-attention/blob/main/llama/train.py
@NanoCode012 NanoCode012 added the enhancement New feature or request label May 30, 2023
@winglian
Copy link
Collaborator

in particular this part: https://github.com/epfml/landmark-attention/blob/main/llama/train.py#L163-L168

@NanoCode012 NanoCode012 mentioned this issue Jun 9, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Add landmark attention NanoCode012/axolotl
2 participants
@winglian @NanoCode012