Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(dynamodb): pitr retention period configuration #32786

Open
2 tasks done
LeeroyHannigan opened this issue Jan 7, 2025 · 2 comments · May be fixed by #32857
Open
2 tasks done

(dynamodb): pitr retention period configuration #32786

LeeroyHannigan opened this issue Jan 7, 2025 · 2 comments · May be fixed by #32857
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@LeeroyHannigan
Copy link
Contributor

Describe the feature

Adding RecoveryPeriodInDays to TableV2 construct.

Use Case

Feature parity with CFN.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

Latest

Environment details (OS name and version, etc.)

MacOS
@LeeroyHannigan LeeroyHannigan added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 7, 2025
@github-actions github-actions bot added the @aws-cdk/aws-dynamodb Related to Amazon DynamoDB label Jan 7, 2025
@LeeroyHannigan
Copy link
Contributor Author

Can assign this to me.

@ashishdhingra ashishdhingra self-assigned this Jan 7, 2025
@ashishdhingra ashishdhingra added p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Jan 7, 2025
@ashishdhingra
Copy link
Contributor

AWS::DynamoDB::Table PointInTimeRecoverySpecification specifies 2 properties - PointInTimeRecoveryEnabled and RecoveryPeriodInDays.

CDK's TableV2 supports pointInTimeRecovery from TableOptionsV2 which is used to set pointInTimeRecoverySpecification > pointInTimeRecoveryEnabled here while configuring replica, but doesn't supports RecoveryPeriodInDays.

Unsure if we should also investigate on why pointInTimeRecoverySpecification is set only for replicas!

@ashishdhingra ashishdhingra added effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jan 7, 2025
@ashishdhingra ashishdhingra removed their assignment Jan 7, 2025
@LeeroyHannigan LeeroyHannigan linked a pull request Jan 11, 2025 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(dynamodb): add pointintimerecoveryspecification and deprecate old LeeroyHannigan/aws-cdk
2 participants
@LeeroyHannigan @ashishdhingra