Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update L1 CloudFormation resource definitions #32768

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

aws-cdk-automation
Copy link
Collaborator

Updates the L1 CloudFormation resource definitions with the latest changes from @aws-cdk/aws-service-spec

L1 CloudFormation resource definition changes:

└[~] service aws-batch
  └ resources
     └[~]  resource AWS::Batch::JobDefinition
        └ types
           ├[~] type EksContainer
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type EksContainerEnvironmentVariable
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type EksContainerVolumeMount
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type EksProperties
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type EksSecret
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type EksVolume
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type EmptyDir
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type HostPath
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type Metadata
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type NodeProperties
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type NodeRangeProperty
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type PodProperties
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           ├[~] type Resources
           │ └      - mustRenderForBwCompat: undefined
           │        + mustRenderForBwCompat: true
           └[~] type SecurityContext
             └      - mustRenderForBwCompat: undefined
                    + mustRenderForBwCompat: true

Updates the L1 CloudFormation resource definitions with the latest changes from `@aws-cdk/aws-service-spec`
@aws-cdk-automation aws-cdk-automation added auto-approve contribution/core This is a PR that came from AWS. dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jan 7, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 7, 2025 03:39
@github-actions github-actions bot added the p2 label Jan 7, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 7, 2025 03:39
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (c199378) to head (ffb2345).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32768   +/-   ##
=======================================
  Coverage   81.52%   81.52%           
=======================================
  Files         222      222           
  Lines       13715    13715           
  Branches     2417     2417           
=======================================
  Hits        11181    11181           
  Misses       2254     2254           
  Partials      280      280           
Flag Coverage Δ
suite.unit 81.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.97% <ø> (ø)
packages/aws-cdk-lib/core 82.09% <ø> (ø)

Copy link
Contributor

mergify bot commented Jan 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 7, 2025
Copy link
Contributor

mergify bot commented Jan 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Jan 7, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link
Contributor

mergify bot commented Jan 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ffb2345
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jan 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 107eed3 into main Jan 7, 2025
19 checks passed
@mergify mergify bot deleted the automation/spec-update branch January 7, 2025 06:19
Copy link

github-actions bot commented Jan 7, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-approve contribution/core This is a PR that came from AWS. dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant