-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(integ-runner): ENOENT
no such file or directory 'recommended-feature-flags.json'
#32750
Conversation
…ure-flags.json' In the `integ-runner`, we used to load the recommended feature flags file for `aws-cdk-lib` using a run-time `readFile` based on a `__dirname`. However, the source files are bundled which makes `__dirname` point to the wrong directory. Instead, load the JSON file directly using a JavaScript `import`, so that the bundler will bundle the JSON file into the source code directly, and we can't fail to load it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32750 +/- ##
=======================================
Coverage 81.38% 81.38%
=======================================
Files 222 222
Lines 13750 13750
Branches 2424 2424
=======================================
Hits 11191 11191
Misses 2279 2279
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ENOENT
no such file or directory 'recommended-feature-flags.json'
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: Pull request #32750 has been dequeued. The pull request has been synchronized by a user You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
In the
integ-runner
, we used to load the recommended feature flags file foraws-cdk-lib
using a run-timereadFile
based on a__dirname
.However, the source files are bundled which makes
__dirname
point to the wrong directory. Instead, load the JSON file directly using a JavaScriptimport
, so that the bundler will bundle the JSON file into the source code directly, and we can't fail to load it.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license