fix(cli): cannot set environment variable CI=false
#32749
Conversation
We check the `$CI` environment variable for its presence, not for its value. This means that setting `CI=false` enables CI mode instead of disabling it. This is unexpected. Fix it. We could have checked for `CI=true` or `CI=1`, but the current behavior is backwards compatible with crazy things users might already be doing.
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
rix0rrr
added
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
removed
the
pr/needs-cli-test-run
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32749 +/- ##
=======================================
Coverage 81.38% 81.38%
=======================================
Files 222 222
Lines 13750 13750
Branches 2423 2424 +1
=======================================
Hits 11191 11191
Misses 2279 2279
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
We check the
$CIenvironment variable for its presence, not for its value. This means that settingCI=falseenables CI mode instead of disabling it.This is unexpected. Fix it.
We could have checked for
CI=trueorCI=1, but the current behavior is backwards compatible with crazy things users might already be doing.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license