fix(cli): cli still fails for some plugins returning expiration: null
#32668
Conversation
There is one more location where we need to convert `null` into `undefined` if a plugin provider returns `expiration: null`. The SDKv3 code base also expects this value to be `undefined | Date`, just like our own code does; when the plugin returns `null` we pass the value over to the SDKv3 which then does a `getTime()` on the value, and then it crashes. Issue this fix as a patch, so that we can unblock users of a commonly used plugin at Amazon.
rix0rrr
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
kaizencc
added
pr-linter/exempt-test
kaizencc
changed the title
expiration: nullexpiration: null
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
There is one more location where we need to convert
nullintoundefinedif a plugin provider returnsexpiration: null. The SDKv3 code base also expects this value to beundefined | Date, just like our own code does; when the plugin returnsnullwe pass the value over to the SDKv3 which then does agetTime()on the value, and then it crashes.Issue this fix as a patch, so that we can unblock users of a commonly used plugin at Amazon.
This is a PR targeting
v2-release, picking exactly one line from #32111. After merging this we can patch-release.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license