Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump jsii 5.5 to 5.6 #32588

Merged
merged 2 commits into from
Dec 19, 2024
Merged

fix: bump jsii 5.5 to 5.6 #32588

merged 2 commits into from
Dec 19, 2024

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Dec 19, 2024

This release drops compatiblity with the long-deprecated jsii 1.x/TypeScript 3.9 version lines, and in doing so reduces compilation times by ~40%.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This release drops compatiblity with the long-deprecated jsii
1.x/TypeScript 3.9 version lines, and in doing so reduces compilation
times by ~40%.
@rix0rrr rix0rrr requested a review from a team December 19, 2024 12:33
@aws-cdk-automation aws-cdk-automation requested a review from a team December 19, 2024 12:33
@github-actions github-actions bot added the p2 label Dec 19, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 19, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@rix0rrr rix0rrr added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Dec 19, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 19, 2024 12:42

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you link to the specific jsii PRs you're hoping to pull with this update?

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Dec 19, 2024

aws/jsii-compiler#1474

@rix0rrr rix0rrr requested review from iliapolo and a team December 19, 2024 12:46
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.86%. Comparing base (c879b5d) to head (4eb8070).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32588   +/-   ##
=======================================
  Coverage   78.86%   78.86%           
=======================================
  Files         108      108           
  Lines        7165     7165           
  Branches     1319     1319           
=======================================
  Hits         5651     5651           
  Misses       1330     1330           
  Partials      184      184           
Flag Coverage Δ
suite.unit 78.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.86% <ø> (ø)

Copy link
Contributor

mergify bot commented Dec 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4eb8070
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 57bba19 into main Dec 19, 2024
17 checks passed
@mergify mergify bot deleted the huijbers/bump-jsii branch December 19, 2024 15:57
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants