-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecs): machineImageType support AL2023 #32509
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32509 +/- ##
=======================================
Coverage 78.80% 78.80%
=======================================
Files 108 108
Lines 7159 7159
Branches 1319 1319
=======================================
Hits 5642 5642
Misses 1332 1332
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment to confirm prior to approving
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
@phuhung273 sorry that I had to revert this PR. As I just discussed with my team internally, there's known issue with the flag usage |
Issue # (if applicable)
Closes #32496
Relate #32469
Reason for this change
Description of changes
machineImageType
support AL2023Description of how you validated changes
Unit + Integration test
Instance can join cluster
iptables command success
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license