-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appsync): add ownerContact
property to the GraphqlApi
#31585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @yasuaki640, can you check out why the build is failing? Looks like there might be an error with the README
@sumupitchayan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. I've made a few comments.
Also, it seems that the description of the Pull request is about EC2 termination.
Could you please correct it to the appropriate description?
packages/@aws-cdk-testing/framework-integ/test/aws-appsync/test/integ.appsync-owner-contact.ts
Outdated
Show resolved
Hide resolved
…t/integ.appsync-owner-contact.ts Co-authored-by: mazyu36 <[email protected]>
Co-authored-by: mazyu36 <[email protected]>
Co-authored-by: mazyu36 <[email protected]>
Co-authored-by: mazyu36 <[email protected]>
@mazyu36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #.
Reason for this change
Because there is no
ownerContact
prop on the aws-appsync graphqlapi.ts L2 layer.Description of changes
Added
ownerContact
prop on the aws-appsync graphqlapi.ts L2 layer.Description of how you validated changes
Added both of unit test and integration test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license