Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appsync): add ownerContact property to the GraphqlApi #31585

Merged
merged 12 commits into from
Oct 7, 2024

Conversation

yasuaki640
Copy link
Contributor

@yasuaki640 yasuaki640 commented Sep 27, 2024

Issue # (if applicable)

Closes #.

Reason for this change

Because there is no ownerContact prop on the aws-appsync graphqlapi.ts L2 layer.

Description of changes

Added ownerContact prop on the aws-appsync graphqlapi.ts L2 layer.

Description of how you validated changes

Added both of unit test and integration test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Sep 27, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 27, 2024 13:55
Copy link
Contributor

@sumupitchayan sumupitchayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @yasuaki640, can you check out why the build is failing? Looks like there might be an error with the README

@yasuaki640
Copy link
Contributor Author

Thanks for the PR @yasuaki640, can you check out why the build is failing? Looks like there might be an error with the README

@sumupitchayan
Fixed README code snippet.
Thanks.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 28, 2024
Copy link
Contributor

@mazyu36 mazyu36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I've made a few comments.

Also, it seems that the description of the Pull request is about EC2 termination.
Could you please correct it to the appropriate description?

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 28, 2024
@yasuaki640
Copy link
Contributor Author

Thank you for your contribution. I've made a few comments.

Also, it seems that the description of the Pull request is about EC2 termination. Could you please correct it to the appropriate description?

@mazyu36
Thank you for the review.
Several fixes have been applied.

Copy link
Contributor

@mazyu36 mazyu36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

sumupitchayan
sumupitchayan previously approved these changes Oct 7, 2024
Copy link
Contributor

mergify bot commented Oct 7, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed sumupitchayan’s stale review October 7, 2024 14:23

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7a63591
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Oct 7, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a8b2f01 into aws:main Oct 7, 2024
10 checks passed
Copy link

github-actions bot commented Oct 7, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants