core: BundlingDockerImage fails unit tests in Amazon Linux 2023 #27712

ymhiroki · 2023-10-27T10:41:03Z

Describe the bug

When I run unit tests for aws-cdk-lib in Amazon Linux 2023, core/test/staging.test.ts fails with invalid docker args.

z, in docker args is inserted in bundling.ts > BundlingDockerImage > run > dockerArgs (link).

isSelinux() returns true in Amazon Linux 2023 and unit tests don't consider the case.

Expected Behavior

The module passes all tests.

Current Behavior

The unit tests fails with errors:

Summary of all failing tests
 FAIL  core/test/staging.test.ts
  ● staging › with bundling

    expect(received).toEqual(expected) // deep equality

    Expected: "run --rm -u 1000:1000 -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS"
    Received: "run --rm -u 1000:1000 -v /input:/asset-input:z,delegated -v /output:/asset-output:z,delegated -w /asset-input alpine DOCKER_STUB_SUCCESS"

      310 |     const assembly = app.synth();
      311 |     expect(
    > 312 |       readDockerStubInput()).toEqual(
          |                              ^
      313 |       `run --rm ${USER_ARG} -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS`,
      314 |     );
      315 |     expect(fs.readdirSync(assembly.directory)).toEqual([

      at Object.<anonymous> (core/test/staging.test.ts:312:30)

  ● staging › bundler reuses its output when it can

    expect(received).toEqual(expected) // deep equality

    Expected: "run --rm -u 1000:1000 -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS"
    Received: "run --rm -u 1000:1000 -v /input:/asset-input:z,delegated -v /output:/asset-output:z,delegated -w /asset-input alpine DOCKER_STUB_SUCCESS"

      389 |     // We're testing that docker was run exactly once even though there are two bundling assets.
      390 |     expect(
    > 391 |       readDockerStubInputConcat()).toEqual(
          |                                    ^
      392 |       `run --rm ${USER_ARG} -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS`,
      393 |     );
      394 |

      at Object.<anonymous> (core/test/staging.test.ts:391:36)

  ● staging › uses asset hash cache with AssetHashType.OUTPUT

    expect(received).toEqual(expected) // deep equality

    Expected: "run --rm -u 1000:1000 -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS"
    Received: "run --rm -u 1000:1000 -v /input:/asset-input:z,delegated -v /output:/asset-output:z,delegated -w /asset-input alpine DOCKER_STUB_SUCCESS"

      434 |     // and that the hash is based on the output
      435 |     expect(
    > 436 |       readDockerStubInputConcat()).toEqual(
          |                                    ^
      437 |       `run --rm ${USER_ARG} -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS`,
      438 |     );
      439 |

      at Object.<anonymous> (core/test/staging.test.ts:436:36)

  ● staging › bundler considers its options when reusing bundle output

    expect(received).toEqual(expected) // deep equality

    - Expected  - 2
    + Received  + 2

    - run --rm -u 1000:1000 -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS
    + run --rm -u 1000:1000 -v /input:/asset-input:z,delegated -v /output:/asset-output:z,delegated -w /asset-input alpine DOCKER_STUB_SUCCESS
    - run --rm -u 1000:1000 -v /input:/asset-input:delegated -v /output:/asset-output:delegated --env UNIQUE_ENV_VAR=SOMEVALUE -w /asset-input alpine DOCKER_STUB_SUCCESS
    + run --rm -u 1000:1000 -v /input:/asset-input:z,delegated -v /output:/asset-output:z,delegated --env UNIQUE_ENV_VAR=SOMEVALUE -w /asset-input alpine DOCKER_STUB_SUCCESS

      482 |     // operating on the same source asset.
      483 |     expect(
    > 484 |       readDockerStubInputConcat()).toEqual(
          |                                    ^
      485 |       `run --rm ${USER_ARG} -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS\n` +
      486 |       `run --rm ${USER_ARG} -v /input:/asset-input:delegated -v /output:/asset-output:delegated --env UNIQUE_ENV_VAR=SOMEVALUE -w /asset-input alpine DOCKER_STUB_SUCCESS`,
      487 |     );

      at Object.<anonymous> (core/test/staging.test.ts:484:36)

  ● staging › bundler re-uses assets from previous synths

    expect(received).toEqual(expected) // deep equality

    Expected: "run --rm -u 1000:1000 -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS"
    Received: "run --rm -u 1000:1000 -v /input:/asset-input:z,delegated -v /output:/asset-output:z,delegated -w /asset-input alpine DOCKER_STUB_SUCCESS"

      596 |
      597 |     expect(
    > 598 |       readDockerStubInputConcat()).toEqual(
          |                                    ^
      599 |       `run --rm ${USER_ARG} -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS`,
      600 |     );
      601 |

      at Object.<anonymous> (core/test/staging.test.ts:598:36)

  ● staging › bundling throws when /asset-output is empty

    expect(received).toEqual(expected) // deep equality

    Expected: "run --rm -u 1000:1000 -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS_NO_OUTPUT"
    Received: "run --rm -u 1000:1000 -v /input:/asset-input:z,delegated -v /output:/asset-output:z,delegated -w /asset-input alpine DOCKER_STUB_SUCCESS_NO_OUTPUT"

      626 |
      627 |     expect(
    > 628 |       readDockerStubInput()).toEqual(
          |                              ^
      629 |       `run --rm ${USER_ARG} -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS_NO_OUTPUT`,
      630 |     );
      631 |   });

      at Object.<anonymous> (core/test/staging.test.ts:628:30)

  ● staging › bundling with BUNDLE asset hash type

    expect(received).toEqual(expected) // deep equality

    Expected: "run --rm -u 1000:1000 -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS"
    Received: "run --rm -u 1000:1000 -v /input:/asset-input:z,delegated -v /output:/asset-output:z,delegated -w /asset-input alpine DOCKER_STUB_SUCCESS"

      649 |     // THEN
      650 |     expect(
    > 651 |       readDockerStubInput()).toEqual(
          |                              ^
      652 |       `run --rm ${USER_ARG} -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS`,
      653 |     );
      654 |     expect(asset.assetHash).toEqual('33cbf2cae5432438e0f046bc45ba8c3cef7b6afcf47b59d1c183775c1918fb1f');

      at core/test/staging.test.ts:651:30
      at Object.fn (../../tools/@aws-cdk/cdk-build-tools/lib/deprecated-symbols.ts:35:5)

  ● staging › bundling with docker security option

    expect(received).toEqual(expected) // deep equality

    Expected: "run --rm --security-opt no-new-privileges -u 1000:1000 -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS"
    Received: "run --rm --security-opt no-new-privileges -u 1000:1000 -v /input:/asset-input:z,delegated -v /output:/asset-output:z,delegated -w /asset-input alpine DOCKER_STUB_SUCCESS"

      674 |     // THEN
      675 |     expect(
    > 676 |       readDockerStubInput()).toEqual(
          |                              ^
      677 |       `run --rm --security-opt no-new-privileges ${USER_ARG} -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS`,
      678 |     );
      679 |     expect(asset.assetHash).toEqual('33cbf2cae5432438e0f046bc45ba8c3cef7b6afcf47b59d1c183775c1918fb1f');

      at Object.<anonymous> (core/test/staging.test.ts:676:30)

  ● staging › bundling with docker entrypoint

    expect(received).toEqual(expected) // deep equality

    Expected: "run --rm -u 1000:1000 -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input --entrypoint DOCKER_STUB_SUCCESS alpine DOCKER_STUB_SUCCESS"
    Received: "run --rm -u 1000:1000 -v /input:/asset-input:z,delegated -v /output:/asset-output:z,delegated -w /asset-input --entrypoint DOCKER_STUB_SUCCESS alpine DOCKER_STUB_SUCCESS"

      699 |     // THEN
      700 |     expect(
    > 701 |       readDockerStubInput()).toEqual(
          |                              ^
      702 |       `run --rm ${USER_ARG} -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input --entrypoint DOCKER_STUB_SUCCESS alpine DOCKER_STUB_SUCCESS`,
      703 |     );
      704 |     expect(asset.assetHash).toEqual('33cbf2cae5432438e0f046bc45ba8c3cef7b6afcf47b59d1c183775c1918fb1f');

      at Object.<anonymous> (core/test/staging.test.ts:701:30)

  ● staging › throws when bundling fails

    expect(received).toEqual(expected) // deep equality

    Expected: "run --rm -u 1000:1000 -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input this-is-an-invalid-docker-image DOCKER_STUB_FAIL"
    Received: "run --rm -u 1000:1000 -v /input:/asset-input:z,delegated -v /output:/asset-output:z,delegated -w /asset-input this-is-an-invalid-docker-image DOCKER_STUB_FAIL"

      817 |     })).toThrow(/Failed to bundle asset stack\/Asset/);
      818 |     expect(
    > 819 |       readDockerStubInput()).toEqual(
          |                              ^
      820 |       `run --rm ${USER_ARG} -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input this-is-an-invalid-docker-image DOCKER_STUB_FAIL`,
      821 |     );
      822 |   });

      at Object.<anonymous> (core/test/staging.test.ts:819:30)

  ● staging › bundling still occurs with partial wildcard

    expect(received).toEqual(expected) // deep equality

    Expected: "run --rm -u 1000:1000 -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS"
    Received: "run --rm -u 1000:1000 -v /input:/asset-input:z,delegated -v /output:/asset-output:z,delegated -w /asset-input alpine DOCKER_STUB_SUCCESS"

      1108 |
      1109 |     expect(
    > 1110 |       readDockerStubInput()).toEqual(
           |                              ^
      1111 |       `run --rm ${USER_ARG} -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS`,
      1112 |     );
      1113 |     expect(asset.assetHash).toEqual('33cbf2cae5432438e0f046bc45ba8c3cef7b6afcf47b59d1c183775c1918fb1f'); // hash of MyStack/Asset

      at Object.<anonymous> (core/test/staging.test.ts:1110:30)

  ● staging › bundling still occurs with a single wildcard

    expect(received).toEqual(expected) // deep equality

    Expected: "run --rm -u 1000:1000 -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS"
    Received: "run --rm -u 1000:1000 -v /input:/asset-input:z,delegated -v /output:/asset-output:z,delegated -w /asset-input alpine DOCKER_STUB_SUCCESS"

      1132 |
      1133 |     expect(
    > 1134 |       readDockerStubInput()).toEqual(
           |                              ^
      1135 |       `run --rm ${USER_ARG} -v /input:/asset-input:delegated -v /output:/asset-output:delegated -w /asset-input alpine DOCKER_STUB_SUCCESS`,
      1136 |     );
      1137 |     expect(asset.assetHash).toEqual('33cbf2cae5432438e0f046bc45ba8c3cef7b6afcf47b59d1c183775c1918fb1f'); // hash of MyStack/Asset

      at Object.<anonymous> (core/test/staging.test.ts:1134:30)


Test Suites: 1 failed, 681 passed, 682 total
Tests:       12 failed, 3 skipped, 11166 passed, 11181 total
Snapshots:   20 passed, 20 total
Time:        157.228 s, estimated 158 s
Ran all test suites.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Reproduction Steps

cd packages/aws-cdk-lib
cd yarn build
cd yarn test

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.103.0

Framework Version

No response

Node.js Version

v20.9.0

OS

Amazon Linux 2023

Language

TypeScript

Language Version

No response

Other information

docker version:

$ docker version
Client:
 Version:           24.0.5
 API version:       1.43
 Go version:        go1.20.10
 Git commit:        ced0996
 Built:             Fri Oct 13 00:00:00 2023
 OS/Arch:           linux/amd64
 Context:           default

Server:
 Engine:
  Version:          24.0.5
  API version:      1.43 (minimum version 1.12)
  Go version:       go1.20.10
  Git commit:       a61e2b4
  Built:            Fri Oct 13 00:00:00 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.7.2
  GitCommit:        0cae528dd6cb557f7201036e9f43420650207b58
 runc:
  Version:          1.1.7
  GitCommit:        f19387a6bec4944c770f7668ab51c4348d9c2f38
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

The text was updated successfully, but these errors were encountered:

pahud · 2023-10-31T19:17:11Z

Interesting. Are you able to run the test on any other ec2 linux distrubutions?

ymhiroki · 2023-11-01T00:36:33Z

I usually develop AWS CDK, run tests, and create Pull Requests on Amazon Linux 2, but I have never seen errors like this. I encountered this issue when trying to set up a new development environment on Amazon Linux 2023.

ymhiroki · 2023-11-09T16:00:31Z

@pahud Do you have any updates or ideas? I can't use Amazon Linux 2023 as a development environment because of this issue. I'm forced to use Node.js v16 on Amazon Linux 2 if it's not resolved. As you know, Node.js v16 is deprecated, and it generates a lot of errors while build 😢.

ymhiroki · 2023-12-03T06:10:29Z

I temporarily resolved this issue by changing the config of the instance to disable SELinux.
This webpage show the steps to set SELINUX in /etc/selinux/config disabled.

ymhiroki added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 27, 2023

github-actions bot added the @aws-cdk/core Related to core CDK functionality label Oct 27, 2023

pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 31, 2023

github-actions bot mentioned this issue Nov 1, 2023

Monthly issue metrics report - October 2023 #27785

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

core: BundlingDockerImage fails unit tests in Amazon Linux 2023 #27712

core: BundlingDockerImage fails unit tests in Amazon Linux 2023 #27712

ymhiroki commented Oct 27, 2023 •

edited

Loading

pahud commented Oct 31, 2023

ymhiroki commented Nov 1, 2023 •

edited

Loading

ymhiroki commented Nov 9, 2023

ymhiroki commented Dec 3, 2023 •

edited

Loading

core: BundlingDockerImage fails unit tests in Amazon Linux 2023 #27712

core: BundlingDockerImage fails unit tests in Amazon Linux 2023 #27712

Comments

ymhiroki commented Oct 27, 2023 • edited Loading

Describe the bug

Expected Behavior

Current Behavior

Reproduction Steps

Possible Solution

Additional Information/Context

CDK CLI Version

Framework Version

Node.js Version

OS

Language

Language Version

Other information

pahud commented Oct 31, 2023

ymhiroki commented Nov 1, 2023 • edited Loading

ymhiroki commented Nov 9, 2023

ymhiroki commented Dec 3, 2023 • edited Loading

ymhiroki commented Oct 27, 2023 •

edited

Loading

ymhiroki commented Nov 1, 2023 •

edited

Loading

ymhiroki commented Dec 3, 2023 •

edited

Loading