Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-cdk-lib/aws-wafv2: ja3fingerprint missing in CDK lib #27590

Closed
2 tasks
xavi-bean opened this issue Oct 18, 2023 · 3 comments
Closed
2 tasks

aws-cdk-lib/aws-wafv2: ja3fingerprint missing in CDK lib #27590

xavi-bean opened this issue Oct 18, 2023 · 3 comments
Labels
@aws-cdk/aws-waf Related to AWS Web Application Firewall feature-request A feature should be added or improved.

Comments

@xavi-bean
Copy link

Describe the feature

The use of ja3 fingerprint is a great new feature offered by AWS WAF. However, this is not available to be set up through cdk-lib yet.

Use Case

To be able to block malicious traffic based on ja3 fingerprint.

Proposed Solution

Update class FieldToMatchProperty from aws_cdk/aws_wafv2 and include ja3fingerprint as a parameter to be used.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.101.0

Environment details (OS name and version, etc.)

N/A

@xavi-bean xavi-bean added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 18, 2023
@github-actions github-actions bot added the @aws-cdk/aws-waf Related to AWS Web Application Firewall label Oct 18, 2023
@khushail khushail self-assigned this Oct 18, 2023
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 18, 2023
@khushail
Copy link
Contributor

khushail commented Oct 19, 2023

Hi @xavi-bean , thanks for reaching out.

upon checking cdk and existing spec file, the property is currently not supported. Hence can't be added by CDK.

However, you could add it to Cloudformation coverage roadmap for the team as a feature.

@khushail khushail removed their assignment Oct 19, 2023
@khushail khushail removed the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Oct 19, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@xavi-bean
Copy link
Author

Thanks for your answer @khushail . Just raised this case for Cloudformation team aws-cloudformation/cloudformation-coverage-roadmap#1833.

Once this is onboarded in Cloudformation is automatically done in CDK at some point? in case not, what has to be done? Open the same case for CDK?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-waf Related to AWS Web Application Firewall feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants