Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: diff should imply --fail by default #27245

Open
l0b0 opened this issue Sep 21, 2023 · 0 comments
Open

core: diff should imply --fail by default #27245

l0b0 opened this issue Sep 21, 2023 · 0 comments
Labels
@aws-cdk/core Related to core CDK functionality feature-request A feature should be added or improved. p2

Comments

@l0b0
Copy link
Contributor

l0b0 commented Sep 21, 2023

Describe the bug

Rather than a separate --fail flag, cdk diff should return a non-zero exit code if there is a diff. This would provide more information to the end user, making it easier to automate cdk diff commands.

Expected Behavior

cdk diff should return zero if there is no difference, and a non-zero exit code if there is a difference.

Current Behavior

cdk diff returns a zero exit code if there is a difference.

Reproduction Steps

Run cdk diff on a stack with differences.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.93.0 (build 724bd01)

Framework Version

No response

Node.js Version

v18.17.1

OS

NixOS

Language

Typescript

Language Version

5.2.2

Other information

No response

@l0b0 l0b0 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 21, 2023
@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Sep 21, 2023
@indrora indrora added p2 feature-request A feature should be added or improved. and removed bug This issue is a bug. labels Sep 21, 2023
@peterwoodworth peterwoodworth removed the needs-triage This issue or PR still needs to be triaged. label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/core Related to core CDK functionality feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

3 participants