Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Mention resource id instead of logical id in logs #11391

Closed
hugomallet opened this issue Nov 10, 2020 · 4 comments
Closed

[core] Mention resource id instead of logical id in logs #11391

hugomallet opened this issue Nov 10, 2020 · 4 comments
Labels
@aws-cdk/core Related to core CDK functionality closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 package/tools Related to AWS CDK Tools or CLI

Comments

@hugomallet
Copy link

Hello,

In order to identify faster the failiing resource in a stack, it would be helpful to mention the resource id instead of the logical id of the resource in logs.

Please see my comment in a previous issue here for context : #5889 (comment)

Thanks


This is a 🚀 Feature Request

@hugomallet hugomallet added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 10, 2020
@hugomallet hugomallet changed the title [aws-cdk] - Mention resource id instead of logical id in logs [aws-cdk] Mention resource id instead of logical id in logs Nov 10, 2020
@SomayaB SomayaB changed the title [aws-cdk] Mention resource id instead of logical id in logs [core] Mention resource id instead of logical id in logs Nov 13, 2020
@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Nov 13, 2020
@SomayaB SomayaB added the package/tools Related to AWS CDK Tools or CLI label Nov 13, 2020
@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 23, 2020

The CDK deploy logs should already show you that ID. Where would you expect to find it?

@hugomallet
Copy link
Author

hugomallet commented Nov 23, 2020

@rix0rrr When there is an error, the ID is not shown. Example:

CREATE_FAILED        | AWS::CloudFormation::CustomResource | DnsValidatedCert
if...orResourceEAF268A7
Failed to create resource. Error: you have reached your limit of 20 certificates in the
last year.

"DnsValidatedCertif...orResourceEAF268A7" is the Logical ID not the one written in my Stack

@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 24, 2020

Hmm, I for sure thought that was in there. I guess not. Thanks for the report.

@rix0rrr rix0rrr added effort/medium Medium work item – several days of effort p1 labels Nov 24, 2020
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Nov 25, 2020
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/core Related to core CDK functionality closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

No branches or pull requests

3 participants