Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: record full prompt in the feedback record #374

Closed
massi-ang opened this issue Feb 13, 2024 · 5 comments
Closed

Enhancement: record full prompt in the feedback record #374

massi-ang opened this issue Feb 13, 2024 · 5 comments
Labels
enhancement New feature or request stale

Comments

@massi-ang
Copy link
Collaborator

massi-ang commented Feb 13, 2024

The user feedback feature introduced in #287 records the user feedback with the following format:

{"feedbackId": "d7911ac5-36e1-449e-ba27-766bb1fdb997", "sessionId": "7d78bb7c-dfd6-4b70-b16c-fd34af42b435", "userId": "xxxxx", "key": "5", "prompt": "About Charle Magn", "completion": "  Sure, I can help with that! Here's a brief overview of Charles Magn:\n\nCharles Magn was a French inventor and engineer who is best known for his work on the first practical typewriter. He was born in 1827 and died in 1909. Magn's typewriter was patented in 1874 and featured a QWERTY keyboard layout that has since become the standard for typewriters and computer keyboards.", "model": "meta.llama2-13b-chat-v1", "feedback": "1", "createdAt": "2024-02-12T21:37:47.881565Z"}

Note that the prompt field contains only the user question, and not the full prompts sent to the LLM, which would consist of a prompt template formatted with the chat history and the user question.

By only recording the user question, the data will not be useful for fine tuning of the model.

We want to record the full prompt, and possibly also the prompt template and template arguments values.

@massi-ang massi-ang added the enhancement New feature or request label Feb 13, 2024
@massi-ang
Copy link
Collaborator Author

@azaylamba Hi Ajay, would you like to take a stab at this since you submitted the PR on user feedback?

@azaylamba
Copy link
Contributor

Sure @massi-ang, I will look into this in a couple of days.

@ryanh-ai
Copy link
Contributor

I think this one can be closed with merge last week

Copy link

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label May 30, 2024
Copy link

This issue was closed because it has been inactive for 30 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
Status: Done
Development

No branches or pull requests

3 participants