Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hydrate is run when only client tasks are allowed #57

Closed
robinmetral opened this issue Nov 13, 2020 · 0 comments · Fixed by #58
Closed

Hydrate is run when only client tasks are allowed #57

robinmetral opened this issue Nov 13, 2020 · 0 comments · Fixed by #58

Comments

@robinmetral
Copy link
Contributor

robinmetral commented Nov 13, 2020 •
edited
Loading

We're using the allowedGroups filter to run the addon only on the client, because SSR tasks are failing on production builds.

Screenshot 2020-11-13 at 11 30 25

The PR for this feature (#40) intended to disable Hydrate (which depends on SSR) for client only configs, however, Hydrate is always ran:

Screenshot 2020-11-13 at 15 06 30

(☝️ the Hydrate task should not be run here)

Reproduce this on the example Storybook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable the Hydrate task on client only configs
1 participant
@robinmetral