Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify error handling in build-dashboard.js #3305

Open
coderabbitai bot opened this issue Oct 20, 2024 · 5 comments · May be fixed by #3521
Open

Simplify error handling in build-dashboard.js #3305

coderabbitai bot opened this issue Oct 20, 2024 · 5 comments · May be fixed by #3521
Labels
area/javascript area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement

Comments

@coderabbitai
Copy link

coderabbitai bot commented Oct 20, 2024

As discussed in PR #3304 (comment), @akshatnema agreed to improve the error handling by throwing errors directly instead of using Promise.reject(e); in the build-dashboard.js script.

We should update the error handling code to throw errors directly, making the asynchronous functions more idiomatic and easier to read.
@github-actions GitHub Actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@lakshaydewan
Copy link

Working on same will be raising a PR soon..

lakshaydewan added a commit to lakshaydewan/website that referenced this issue Oct 21, 2024
@lakshaydewan
fix:Simplify error handling(asyncapi#3305)
eb7ca25
@lakshaydewan
Copy link

lakshaydewan commented Oct 21, 2024 •
edited
Loading

PR #3310 fixes the issue needs a review though..

@coderabbitai coderabbitai bot mentioned this issue Oct 21, 2024
Closed
lakshaydewan added a commit to lakshaydewan/website that referenced this issue Oct 21, 2024
@lakshaydewan
fix:Simplify-error-handling(asyncapi#3305)
41aaa49
@coderabbitai coderabbitai bot mentioned this issue Oct 21, 2024
Closed
@yuvrajkarna2717
Copy link

Hello, I noticed this issue and would like to contribute. Is it still open for work?

@anshgoyalevil anshgoyalevil added enhancement area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. area/javascript labels Dec 26, 2024
@krishkumar84
Copy link

hey assign this issue to me i want to contribute in this

@sahitya-chandra sahitya-chandra linked a pull request Dec 28, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/javascript area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: simplified error handling in build-dashboard.js sahitya-chandra/asyncAPI-website
5 participants
@akshatnema @anshgoyalevil @krishkumar84 @lakshaydewan @yuvrajkarna2717