Skip to content
This repository has been archived by the owner on Nov 1, 2018. It is now read-only.

AspNetCoreModule needs to abort failed responses #39

Closed
Tratcher opened this issue Nov 19, 2015 · 8 comments
Closed

AspNetCoreModule needs to abort failed responses #39

Tratcher opened this issue Nov 19, 2015 · 8 comments

Comments

@Tratcher
Copy link
Member

aspnet/KestrelHttpServer#341 (comment)

If the back-end server fails while writing out the response body (after the first 8kb) and closes/resets the connection, platform handler does not correctly fail the response to the client.

For a chunked request that fails sometime before the final chunked terminator the handler mistakenly adds the missing terminator. This is problematic because it tells the client the response completed successfully. It should have just closed/reset the connection.

Content-Length responses that fail after sending 8kb just hang.

@Tratcher Tratcher changed the title HttpPlatformHandler needs to abort failed chunked responses HttpPlatformHandler needs to abort failed responses Nov 19, 2015
@Tratcher Tratcher modified the milestone: 1.0.0-rc2 Jan 13, 2016
@muratg
Copy link
Contributor

muratg commented Feb 8, 2016

@Tratcher is this still pending?

@Tratcher Tratcher self-assigned this Mar 17, 2016
@Tratcher
Copy link
Member Author

I tested with private builds and the behavior has improved, but it is still intermittently incorrect, especially if only a small amount of data has been sent before the back-end connection closes.

@Tratcher Tratcher modified the milestones: 1.0.0, 1.0.0-rc2 Mar 28, 2016
@Tratcher Tratcher added the bug label Mar 30, 2016
@shirhatti shirhatti modified the milestones: 1.0.1, 1.0.0 May 23, 2016
@Tratcher Tratcher changed the title HttpPlatformHandler needs to abort failed responses AspNetCoreModule needs to abort failed responses Jun 14, 2016
@shirhatti shirhatti assigned Tratcher and unassigned pan-wang Jul 29, 2016
@Tratcher
Copy link
Member Author

Tratcher commented Aug 5, 2016

@rynowak, @glennc said you keep running into this as a response truncation issue?

@glennc
Copy link
Member

glennc commented Aug 5, 2016

@rynowak When using IIS the problem of JSON.NET throwing on circular models is exacerbated by the ANCM not severing the connection appropriately.

I can use HTTPClient to grab data from a web api in my controller and send that to a view, and not know that anything is broken if I don't have much data. In my case it was happily showing a single result on my page, and leaving out the rest. I didn't even realize until I moved it to Linux and then I would get exceptions and the app would fail.

@muratg
Copy link
Contributor

muratg commented Aug 17, 2016

@shirhatti Is the change not in ANCM? Why assign it back to @Tratcher

@shirhatti
Copy link
Contributor

@shirhatti
Copy link
Contributor

@muratg I'll assign it to @jhkimnew to further investigate

@shirhatti shirhatti assigned shirhatti and unassigned Tratcher Aug 17, 2016
@Tratcher
Copy link
Member Author

This issue was moved to aspnet/AspNetCoreModule#26

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants